Fix warning about missing delcandidates table in director#1721
Fix warning about missing delcandidates table in director#1721BareosBot merged 3 commits intobareos:masterfrom
Conversation
arogge
left a comment
There was a problem hiding this comment.
Thank you very much for taking the time working on this.
While the solution is probably correct (i.e. setting client_min_messages to WARNING), I would want you to implement it differently.
d747091 to
585aa23
Compare
|
I really don't know why we have three instances of that initialization code, but I'll try to replicate your change to the others. |
|
Sorry, I force pushed the change a few weeks ago but forgot to write comment. Please have a look whether it now is now done at the correct location. |
There was a problem hiding this comment.
Great work. Thanks for taking the time to do this!
I removed an unused function (that would have require the same change) and added your change to the reconnect initialization, too.
If you're still happy with it, I'll accept the changes and backport them to Bareos 23.
Pruning jobs would cause the following warning in the output of the director (e.g. visible through “systemctl status bareos-director.service”): table "delcandidates" does not exist, skipping This warning is harmless but clutters the output. With this commit, this problem is fixed by disabling warnings for the PostgreSQL connection that is established by the director. See https://bugs.bareos.org/view.php?id=1561 and https://bugs.bareos.org/view.php?id=1606.
595c2f7 to
800dec0
Compare
|
Yes, this looks good to me. |
Pruning jobs would cause the following warning in the output of the director (e.g. visible through
systemctl status bareos-director.service):This warning is harmless but clutters the output. With this PR, this problem is fixed by disabling warnings for the PostgreSQL connection that is established by the director.
See https://bugs.bareos.org/view.php?id=1561 and https://bugs.bareos.org/view.php?id=1606.
Please check
If you have any questions or problems, please give a comment in the PR.
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality