crypto_wrap: replace aes wrap with openssl aes wrap algorithm#1718
Merged
BareosBot merged 8 commits intobareos:masterfrom Mar 8, 2024
Merged
crypto_wrap: replace aes wrap with openssl aes wrap algorithm#1718BareosBot merged 8 commits intobareos:masterfrom
BareosBot merged 8 commits intobareos:masterfrom
Conversation
875f7e7 to
db6eb6b
Compare
25cbe90 to
619e0bd
Compare
f136a97 to
505134a
Compare
Now the plaintext that is getting wrapped/unwrapped is not static but instead is randomised.
The test now has the old implementation instead.
dev->poll disables AutoLabeling, as such we should not leak it into the caller context.
505134a to
efed11b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR switches AesWrap/AesUnwrap from our implementation of that algorithm to the openssl implementation.
A unit test was added that checks that the two implementations behave the same.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineRequired backport PRs have been createdSource code quality
Tests