Bugfix: Clean up error handling in LDAP plugin, fix dependencies#1717
Merged
BareosBot merged 6 commits intobareos:masterfrom Mar 7, 2024
Merged
Conversation
sebsura
reviewed
Feb 23, 2024
181ee16 to
a61559c
Compare
joergsteffens
approved these changes
Feb 28, 2024
6 tasks
- handle referrals in search results - better error reporting when using incorrect base DN - refactor reporting of LDAP exceptions - replace old-style % operator with format() - Debian package build: fix dependencies for python-ldap Fixes: bareos#1599: FD LDAP Plugin has broken dependencies on Debian 11+
Accept SYSTEMTEST_LDAP_ADDRESS with port number, like SYSTEMTEST_LDAP_ADDRESS=127.0.0.1:389
Also test how the plugin behaves with wrong credentials.
7e4dfde to
e2561d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Bugfix: Clean up error handling in LDAP plugin
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests