build: Fix debugsource RPM package generation#1713
Merged
BareosBot merged 5 commits intobareos:masterfrom Mar 7, 2024
Merged
Conversation
b46b667 to
ac3926b
Compare
pstorz
approved these changes
Feb 27, 2024
by using the DebugEdit module we add a POST_BUILD command to each CMake target that generates ELF binaries if we have debugedit available. This command will basically undo the job of -fdebug-prefix-map. The idea here is that we want to have all object files with canonical paths in ccache, but the resulting binaries should have the non-canonical path embedded so debuginfo/debugsource generation will work correctly.
ac3926b to
e5c3b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reconfigures the build to
While this may seem counter-intuitive, we need the canonical /usr/src/bareos path to be in ccache so it actually caches.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality