dbcheck: fix dbcheck crash if password is not set in catalog resource#1710
Merged
BareosBot merged 5 commits intobareos:masterfrom Mar 11, 2024
Merged
Conversation
sebsura
commented
Feb 22, 2024
sebsura
commented
Feb 22, 2024
0becac2 to
c46f9e7
Compare
Contributor
Author
|
Need to fix the bahavior with invalid directory names as well! |
a7a20c7 to
2d85b2d
Compare
ef2037f to
aa6363b
Compare
This was referenced Mar 8, 2024
We now set the strings to be empty if the value it shouldve been assigned is null. This can happen if the configuration is missing.
There is very little reason for this debug message to have level 20.
I added some files that specifically have names containing
< (less than)
> (greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)
* (asterisk)
as there are illegal in normal windows paths.
789b89f to
fb4cc30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality