bareos-triggerjob: fix parameter handling#1708
Merged
BareosBot merged 3 commits intobareos:masterfrom Feb 8, 2024
Merged
Conversation
bruno-at-bareos
requested changes
Feb 8, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Nice improvements, there's some questions and changes needed.
96124d0 to
45b5d97
Compare
bruno-at-bareos
approved these changes
Feb 8, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks, everything is now ok.
Please create appropriate backport for 23
4 tasks
To better distinguish between standard connection options and additional custom options, use a argument group for the standard options.
Fixes problems in parameter handling and apply some changes proposed by pylint.
a762867 to
5eae80e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parameter handling of bareos-triggerjob (contrib)
and improve parameter help string of standard parameter.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality