cmake: put generated files into CMAKE_BINARY_DIR#1707
Merged
Conversation
e71a697 to
4d59085
Compare
Contributor
|
Don't we want to also move the generated part of the webui ? |
pstorz
requested changes
Feb 27, 2024
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good, please resolve conflict.
4d59085 to
f3f33be
Compare
Contributor
|
I fixed the conflict. |
f3f33be to
7288f34
Compare
pstorz
approved these changes
Mar 11, 2024
instead of just configuring a lot of files this now allows to configure specific files or globbed files either into the source tree or (by default) into the binary directory.
Instead of configuring all .in files, the CMakeLists now configure only the files they need and put those in the output directory
Instead of configuring all .in files, the CMakeLists now configure only the files they need and put those in the output directory
those files should be ignored with a per-user and not a per-project gitignore (i.e. in ~/.config/git/ignore).
we now configure the core/src/tests/configs directory into the binary tree to not pollute the source tree. This required some changes to the tests, as the configuration is now loaded using a relative path.
Previously all to-be-installed configuration files were taken from the source tree. As some of them need to be configured we stage all configuration files in the binary dir during configuration first and install from there.
Instead of just generating all the files for the debian build into the debian directory, we now generate them into CMAKE_BINARY_DIR and only copy them when the generate-debian-control target is built (that already regenerates the main control file).
658ca41 to
6f202e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR strives to move as much of the files generated by cmake into the CMAKE_BINARY_DIR instead of putting them into the source tree.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality