windows: fix calculation of "job_metadata.xml" object size#1695
Merged
BareosBot merged 3 commits intobareos:masterfrom Feb 7, 2024
Merged
windows: fix calculation of "job_metadata.xml" object size#1695BareosBot merged 3 commits intobareos:masterfrom
BareosBot merged 3 commits intobareos:masterfrom
Conversation
3427238 to
4b75dd0
Compare
pstorz
approved these changes
Feb 2, 2024
This was referenced Feb 6, 2024
BSTR_2_str converts the wide string into a multibyte string. As such wcslen * sizeof(wchar_t) is just wrong. This leads to a SIGSEV on windows sometimes.
76b80d9 to
c26a8a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR fixes an issue on windows that causes bareos to miscalculate the size of a restore object. This may cause the fd to crash.
This PR also removes the use of a vla inside our glob compability layer.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests