Skip to content

stored: fix storage daemon crash if passive client is unreachable, create better session keys#1688

Merged
BareosBot merged 6 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-passive-client-crash
Feb 8, 2024
Merged

stored: fix storage daemon crash if passive client is unreachable, create better session keys#1688
BareosBot merged 6 commits intobareos:masterfrom
sebsura:dev/ssura/master/fix-passive-client-crash

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented Jan 29, 2024

Thank you for contributing to the Bareos Project!

This pr fixes some crashes related to passive clients.
It also slightly alters how the sd generates session keys.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura force-pushed the dev/ssura/master/fix-passive-client-crash branch 2 times, most recently from 2635e68 to 0b4aa75 Compare January 29, 2024 07:51
@sebsura sebsura changed the title stored: fix passive client crash stored: fix storage daemon crash if passive client is unresponsive Jan 30, 2024
@sebsura sebsura changed the title stored: fix storage daemon crash if passive client is unresponsive stored: fix storage daemon crash if passive client is unreachable Jan 30, 2024
@pstorz pstorz changed the title stored: fix storage daemon crash if passive client is unreachable stored: fix storage daemon crash if passive client is unreachable, create better session keys Feb 2, 2024
@sebsura sebsura force-pushed the dev/ssura/master/fix-passive-client-crash branch from ee69f5a to f3b5cd8 Compare February 8, 2024 06:22
@BareosBot BareosBot merged commit 21c86c4 into bareos:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants