core: Fix compile errors on GCC 14#1687
Merged
BareosBot merged 4 commits intobareos:masterfrom Feb 14, 2024
Merged
Conversation
Member
|
Thank you for taking the time to fix this. I'll also backport this change into Bareos 23. Do you also need this in older versions (i.e. 22 and 21)? |
arogge
approved these changes
Jan 31, 2024
6 tasks
Contributor
Author
|
Happy to help! If it's not too much trouble, backporting to 22 would be nice, thank you! |
arogge
requested changes
Jan 31, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
I guess you're bulding without gtest installed. There is another missing #include <algorithm> in core/src/tests/addresses_and_ports_config.cc
Would you fix that aswell or should I do it?
Contributor
Author
|
Sorry for the delayed response! I'll be happy to do it if you haven't already. |
Member
|
Sure, go on. I'll happily backport it afterwards :) |
arogge
approved these changes
Feb 13, 2024
6 tasks
Starting in GCC 14, it will no longer include <algorithm> by default, resulting in compile errors for various projects. https://gcc.gnu.org/gcc-14/porting_to.html Errors: core/src/cats/sql_get.cc:1309:42: error: cannot convert 'std::vector<std::__cxx11::basic_string<char> >::iterator' to `const char*' 1309 | jobids.erase(std::remove(jobids.begin(), jobids.end(), remove_jobid), core/src/stored/append.cc:78:3: error: `for_each' was not declared in this scope 78 | for_each(attributes_.begin(), attributes_.end(), core/src/dird/ua_prune.cc:897:27: error: `remove_if' is not a member of `std'; did you mean `remove_cv'? 897 | prune_list.erase(std::remove_if(prune_list.begin(), prune_list.end(), Signed-off-by: Christopher Fore <csfore@posteo.net>
67e4141 to
acbc377
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting in GCC 14, it will no longer include
<algorithm>by default, resulting in compile errors for various projects.https://gcc.gnu.org/gcc-14/porting_to.html
Errors:
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality