python-bareos: integrate usage of config files#1678
Merged
BareosBot merged 7 commits intobareos:masterfrom Jan 30, 2024
Merged
Conversation
38719c0 to
12bf70e
Compare
51e4ec1 to
7b4ccc1
Compare
7b4ccc1 to
d2ae948
Compare
bruno-at-bareos
requested changes
Jan 29, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Will be a nice improvement. See comments for changes.
contrib/misc/bareos_pam_integration/pam_exec_add_bareos_user.py
Outdated
Show resolved
Hide resolved
32b7365 to
0640b6a
Compare
instead of argparse.
Python 2 is no longer supported. Also the python-bareos packages for Debian >= 12 and Ubuntu 22.04 have been created without content.
0640b6a to
8fedbed
Compare
Create also the root database in case of tests in podman rootless Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Bruno Friedmann @bareos <89836284+bruno-at-bareos@users.noreply.github.com>
8fedbed to
b677221
Compare
bruno-at-bareos
approved these changes
Jan 29, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for this excellent improvement.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends python-bareos to retrieve its parameter via config file.
It does so, by replacing argparse by configargparse.
Because configargparse is not available as package on all platforms,
it still falls back to argparse.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests