Make BareosDirPluginPrometheusExporter.py work with python3#1647
Merged
BareosBot merged 3 commits intobareos:masterfrom Jan 24, 2024
Merged
Make BareosDirPluginPrometheusExporter.py work with python3#1647BareosBot merged 3 commits intobareos:masterfrom
BareosBot merged 3 commits intobareos:masterfrom
Conversation
sduehr
reviewed
Jan 10, 2024
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution, looks good.
I took the chance to add a commit that reformats the code using black and applies some minor changes which were suggested by flake8.
Member
|
Do you want that your name appears in the AUTHORS file? |
This was referenced Jan 19, 2024
sduehr
approved these changes
Jan 23, 2024
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution.
Apply code formatting using black and a few minor changes which were suggested by flake8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
With this minor change the prometheus plugin works with python3.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality