python-bareos: use socket.create_connection() to allow AF_INET6#1646
Merged
BareosBot merged 2 commits intobareos:masterfrom Jan 8, 2024
Conversation
c1a1655 to
608ee5c
Compare
sebsura
reviewed
Jan 3, 2024
0908e88 to
7c36267
Compare
7c36267 to
677e15f
Compare
sebsura
requested changes
Jan 5, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
This is a great change. I added some comments for things i would change.
10 tasks
Contributor
|
pr-tool reported the following: |
ba7d452 to
f98477b
Compare
- remove hard-coded AF_INET in socket creation. - replace socket.connect() by a higher-level function socket.create_connection() allowing AF_INET6 familly connection. - set a default of 30 to self.timeout, simplify code to remove `if self.timeout ...` Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
b435feb to
5ab0d6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR remove the hard-coded restriction on AF_INET Familly by using use a higher-level function socket.create_connection() .
This allow connection to bareos daemon with AF_INET6 familly.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality