Skip to content

Fix continuation on colons in plugin baseclass#1637

Merged
BareosBot merged 3 commits intobareos:masterfrom
arogge:dev/arogge/master/fix-plugindef-colons
Dec 19, 2023
Merged

Fix continuation on colons in plugin baseclass#1637
BareosBot merged 3 commits intobareos:masterfrom
arogge:dev/arogge/master/fix-plugindef-colons

Conversation

@arogge
Copy link
Member

@arogge arogge commented Dec 18, 2023

Due to an oversight PR #1605 broke continuation of option-values in the plugindef like this:

Plugin = "python3-fd:module_name=whatever::masked-colon=one\\:two\\:three"

This PR improves the systemtest and contains the (rather trivial) fix.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

This adds an option with masked colons to the plugindef in the fileset.
This fixes continuation on colons in the base-class.
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@sduehr sduehr assigned arogge and unassigned sduehr Dec 18, 2023
@BareosBot BareosBot merged commit c3eb763 into bareos:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants