Skip to content

dird: fix purge oldest volume#1629

Merged
BareosBot merged 2 commits intobareos:bareos-23from
pstorz:dev/pstorz/bareos-23/backport-1628
Dec 13, 2023
Merged

dird: fix purge oldest volume#1629
BareosBot merged 2 commits intobareos:bareos-23from
pstorz:dev/pstorz/bareos-23/backport-1628

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 12, 2023

Fixes 0001580: Purge Oldest Volume stops working since update

When we introduced confirmation for the purge volume command we accidentially broke purge oldest volume. This patch fixes the problem and adds a test.

(cherry picked from commit acde2d1)

Thank you for contributing to the Bareos Project!

Backport of PR #1628 to bareos-23

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Fixes 0001580: Purge Oldest Volume stops working since update

When we introduced confirmation for the purge volume command we
accidentially broke purge oldest volume. This patch fixes the problem
and adds a test.

(cherry picked from commit acde2d1)
@BareosBot BareosBot merged commit 639dd30 into bareos:bareos-23 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants