dird: fix purge oldest volume#1629
Merged
BareosBot merged 2 commits intobareos:bareos-23from Dec 13, 2023
Merged
Conversation
Fixes 0001580: Purge Oldest Volume stops working since update When we introduced confirmation for the purge volume command we accidentially broke purge oldest volume. This patch fixes the problem and adds a test. (cherry picked from commit acde2d1)
arogge
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 0001580: Purge Oldest Volume stops working since update
When we introduced confirmation for the purge volume command we accidentially broke purge oldest volume. This patch fixes the problem and adds a test.
(cherry picked from commit acde2d1)
Thank you for contributing to the Bareos Project!
Backport of PR #1628 to bareos-23
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests