dird: remove optimize_for_size/optimize_for_speed#1612
Merged
BareosBot merged 7 commits intobareos:masterfrom Dec 12, 2023
Merged
dird: remove optimize_for_size/optimize_for_speed#1612BareosBot merged 7 commits intobareos:masterfrom
BareosBot merged 7 commits intobareos:masterfrom
Conversation
pstorz
requested changes
Dec 5, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good! Only one typo in the comment.
Backport needs only to deprecate the directives.
Good work!
79b5dbc to
d156189
Compare
d156189 to
078896d
Compare
11 tasks
b120273 to
f6a05ba
Compare
pstorz
requested changes
Dec 7, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good, but why do we have so many empty files?(.rst.inc).
I guess we can leave them away?
pstorz
approved these changes
Dec 11, 2023
daa633a to
3ddf9cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR removes the
optimize_for_*options from the director. It also fixes a memory leak.It also includes a fix for a memory leak inside the director.
The backport to 23 will only contain the deprecation of these options.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality