Remove unnecessary loader/module split in Python modules for the FD#1602
Merged
BareosBot merged 11 commits intobareos:masterfrom Nov 24, 2023
Merged
Conversation
This patch makes the plugin compatible to PostgreSQL 10 again.
Just returning bRC_Error from load_bareos_plugin() is apparently not enough to make Bareos fail the backup. Thus we emit an M_FATAL instead of an M_ERROR to fast-fail the job. This also fixes a subtle bug in the class decorator: as we weren't returning the class, the class itself was not available under its name which could lead to strange effects.
5f988c2 to
24598af
Compare
sduehr
approved these changes
Nov 23, 2023
Member
sduehr
left a comment
There was a problem hiding this comment.
Thanks, looks good.
Documentation changes are not really required, but we should add some lines about the decorator to the developer guide in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it all: this PR merges the actual plugin-module into each plugin-loader, as we moved the job of almost everything in the loader to a decorator a few months ago.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality