Enable automatic cpu-dependent dispatch for xxHash#1601
Merged
BareosBot merged 5 commits intobareos:masterfrom Nov 24, 2023
Merged
Enable automatic cpu-dependent dispatch for xxHash#1601BareosBot merged 5 commits intobareos:masterfrom
BareosBot merged 5 commits intobareos:masterfrom
Conversation
df6bd9b to
e925627
Compare
d66dcb6 to
76b8b59
Compare
76b8b59 to
60001e3
Compare
60001e3 to
f7e68f4
Compare
pstorz
approved these changes
Nov 23, 2023
Previously, we blindly used xxh3.h to have xxhash inlined completely. While this provides decent performance, we can do better. Based on wheter using bundled xxhash and the target platform, we automatically select which header to include to get either the dynamically linked system-provided library, an optimized algorithm based on the CPU's features selected at runtime or just the plain variant of xxhash. We also configure the bundled xxhash library to be built with -O3.
Previously, if you built Bareos without setting any options yourself, you would get an unoptimized build. With this patch, if you do not set any C and C++ compiler flags and also did not select a CMake build-type, we will automatically set the build-type to RelWithDebInfo (i.e. some optimizations, but with full debugging symbols). As we don't want to have assertions disabled in our builds, CMake will now also filter out the flags -DNDEBUG and /DNDEBUG from all build-type defaults.
f7e68f4 to
398c483
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables dynamic dispatch for xxHash on x86-64 (which is the only platform that supports this).
It also adds a benchmark to compare performance of the different digests.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests