plugins: fix cancel handling crash#1595
Merged
BareosBot merged 14 commits intobareos:masterfrom Dec 22, 2023
Merged
Conversation
fec50f9 to
8d3bd61
Compare
4dbd0bd to
f4819ec
Compare
Contributor
|
Tested cancel during file/dir building ok and also during backuping file ... all ok with nice backlog. |
03a0506 to
d28a63e
Compare
d28a63e to
034d5e7
Compare
arogge
requested changes
Dec 20, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
I have a few open questions and some change-requests for the python test-plugin.
systemtests/tests/py3plug-fd-basic/python-modules/cancel-check-module.py
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/python-modules/cancel-check-module.py
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/python-modules/cancel-check-module.py
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/python-modules/cancel-check-module.py
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/testrunner-cancel-check-no-wait
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I was notified of a problem in regards with this pull request. Ill request a rereview once I fixed the it. |
arogge
requested changes
Dec 21, 2023
f96eed2 to
d933d5d
Compare
13 tasks
Each seperate thread needs its own python thread state to do things inside of python.
The new test tries to cancel the job while the job is inside the plugin module. This is to check whether there are any crashes.
This allows us to test what happens if the plugin finishes the backup while the cancelation is still ongoing.
This prevents the situation where one thread is still trying to cancel something while another is already destroying parts of the jcr.
On windows one hase to use ::closesocket() instead of ::close() to close sockets. See: bsock_tcp.cc:50-58
5287c26 to
aa43c0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The plugin context is not explicitly set when handling plugin events. This is fine for all events except for the cancel event, since the cancel event is issued on seperate threads (and the plugin context is stored in a thread local variable).
This PR fixes the crash by setting the plugin context whenever an event needs to be handled.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality
Tests