Merged
Conversation
sebsura
requested changes
Nov 7, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good. I added some suggestions, tell me what you think of them.
bc9e03b to
6a59187
Compare
Member
Author
|
I had to rebase and force-push to fix some conflicts. Sorry for that. |
6a59187 to
5830693
Compare
sebsura
requested changes
Nov 9, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
You cannot remove ini.h and ini.cc since they are actually required by test-plugin-fd.cc.
If that file is not used anymore, we should probably delete it as well.
Member
Author
|
That test plugin looks like something that bitrotted away. At least there is no build configuration on Jenkins that would even try to build it. |
5830693 to
9bfcd79
Compare
the classic gettext macro _() clashes with some uses of underscore, to mitigate that, this commit renames it to T_().
there is no functional difference, it is just one more macro removed.
9bfcd79 to
99354a6
Compare
sebsura
approved these changes
Nov 17, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Good work! You just need to fix the build issues but Ill already approve of it for now.
99354a6 to
0086d54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineRequired backport PRs have been createdSource code quality
Required documentation changes are present and part of the PR