Skip to content

python-bareos: add timeout setting when connecting to the director.#1583

Merged
BareosBot merged 4 commits intobareos:masterfrom
tuxmaster5000:timeout
Nov 2, 2023
Merged

python-bareos: add timeout setting when connecting to the director.#1583
BareosBot merged 4 commits intobareos:masterfrom
tuxmaster5000:timeout

Conversation

@tuxmaster5000
Copy link
Contributor

@tuxmaster5000 tuxmaster5000 commented Nov 1, 2023 •
edited by joergsteffens
Loading

Thank you for contributing to the Bareos Project!

Adds a the command line parameter for setting a timeout value when connecting to the Bareos Director.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@tuxmaster5000
Copy link
Contributor Author

tuxmaster5000 commented Nov 1, 2023

Why will the check's fail?
On local environment, the patch will done it's job.

@joergsteffens joergsteffens self-requested a review November 2, 2023 09:39
@joergsteffens joergsteffens self-assigned this Nov 2, 2023
@joergsteffens joergsteffens changed the title Add timeout setting when connecting to the director. python-bareos: add timeout setting when connecting to the director. Nov 2, 2023
joergsteffens
joergsteffens approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks helpful.

@joergsteffens
Copy link
Member

joergsteffens commented Nov 2, 2023

The tests did run through. The error show was due to pr-tool complaining about Python formatting.
I applied the changes suggested by bareos-check-sources. Besides that, I think this change can be helpful, so I approved it.

@BareosBot BareosBot merged commit c5f6766 into bareos:master Nov 2, 2023
@tuxmaster5000 tuxmaster5000 deleted the timeout branch November 3, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joergsteffens joergsteffens joergsteffens approved these changes

Assignees

@joergsteffens joergsteffens

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tuxmaster5000 @joergsteffens @BareosBot