configuration: deprecate base jobs#1580
Merged
BareosBot merged 7 commits intobareos:masterfrom Nov 13, 2023
Merged
Conversation
2c0be93 to
462706b
Compare
arogge
previously requested changes
Nov 2, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
in core/src/dird/dird_conf.cc we have JobResource::Validate() that should probably also check if Level = Base and store a configuration warning.
sebsura
reviewed
Nov 13, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good. We should probably add a warning to TasksAndConcepts/FileDeduplicationUsingBaseJobs.html saying that base jobs are deprecated as well.
sebsura
requested changes
Nov 13, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I think we should also deprecate
Dir->Fileset->Include->Options->BaseJob
Since it only does something when base jobs are involved afaik.
It should be found in inc_conf.cc.
The unused and undocumented option Base inside inc_conf.cc should also be deprecated now so that we can remove it next release.
f5ace6b to
2b770e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests