database: media table: use bigint instead of integer#1579
Merged
BareosBot merged 10 commits intobareos:masterfrom Nov 6, 2023
Merged
database: media table: use bigint instead of integer#1579BareosBot merged 10 commits intobareos:masterfrom
BareosBot merged 10 commits intobareos:masterfrom
Conversation
bruno-at-bareos
requested changes
Oct 26, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
First round of review looks ok (build,systemtest) but see remarks.
bruno-at-bareos
approved these changes
Oct 30, 2023
8f825cf to
698c5c4
Compare
698c5c4 to
d83884b
Compare
949ac2d to
74f437b
Compare
bruno-at-bareos
approved these changes
Nov 6, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for the good work. I approve this PR for master.
Local build, tests controls are all green.
Let finish Jenkins.
Unfortunately, psql returns with OK even in case of error when the transaction was rolled back. To make sure the update was correctly performed, we now only have one transaction during update from 2210_2230 and verify afterwards that the version was updated.
- fix OP#5573 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit 292285a)
d2c8613 to
740dd49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR aims to fix an integer out of range in media table which may occur in rare consistencies where the volume is reused in a very high frequency.
It include fixes to allow using PG16 as database backend for bareos 23+
#OP5292
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality