Skip to content

tls: add tls v1.3 configuration option#1577

Merged
BareosBot merged 15 commits intobareos:masterfrom
sebsura:dev/ssura/master/add-tls13-configuration
Oct 27, 2023
Merged

tls: add tls v1.3 configuration option#1577
BareosBot merged 15 commits intobareos:masterfrom
sebsura:dev/ssura/master/add-tls13-configuration

Conversation

@sebsura
Copy link
Contributor

@sebsura sebsura commented Oct 17, 2023

Thank you for contributing to the Bareos Project!

Adds a simple configuration option that allows the user to select which tls cipher he wishes to use.
One caveat is that currently only SHA256 ciphers are supported; this in effect means that currently
the cipher TLS_AES_256_GCM_SHA384 is not supported.

This PR also adds a config option to make bareos tell openssl to use ktls if it can.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura force-pushed the dev/ssura/master/add-tls13-configuration branch 6 times, most recently from 5f1312c to cd9a260 Compare October 17, 2023 13:41
@bruno-at-bareos bruno-at-bareos self-requested a review October 19, 2023 10:07
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to test kTLS somehow?
I think would make sense to at least have a test that enables kTLS and checks if it is enabled somehow.

@sebsura sebsura requested a review from pstorz October 24, 2023 08:08
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Please see comments.

@pstorz pstorz self-requested a review October 24, 2023 08:58
@sebsura sebsura force-pushed the dev/ssura/master/add-tls13-configuration branch 3 times, most recently from fc058ea to 69e458a Compare October 25, 2023 07:56
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! See comments.

@sebsura sebsura force-pushed the dev/ssura/master/add-tls13-configuration branch from effcb91 to 3eb88db Compare October 26, 2023 14:18
@sebsura sebsura force-pushed the dev/ssura/master/add-tls13-configuration branch 2 times, most recently from 0976e34 to 0208820 Compare October 27, 2023 08:33
@sebsura sebsura force-pushed the dev/ssura/master/add-tls13-configuration branch from 0208820 to cffc621 Compare October 27, 2023 08:40
@pstorz pstorz removed the request for review from bruno-at-bareos October 27, 2023 09:40
@BareosBot BareosBot merged commit 9c3b6a3 into bareos:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants