Skip to content

bareos-check-sources: ignore bootstrap*.css#1556

Merged
BareosBot merged 2 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/check-sources-ignore-bootstrap
Sep 16, 2023
Merged

bareos-check-sources: ignore bootstrap*.css#1556
BareosBot merged 2 commits intobareos:masterfrom
joergsteffens:dev/joergs/master/check-sources-ignore-bootstrap

Conversation

@joergsteffens
Copy link
Member

@joergsteffens joergsteffens commented Sep 15, 2023

The bareos-webui uses bootstrap
and therefore we include bootstrap files in our repo. bareos-check-sources should not modify these files and therefore we exclude them.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

The bareos-webui uses bootstrap
and therefore we include bootstrap files in our repo.
bareos-check-sources should not modify these files
and therefore we exclude them.
@pstorz pstorz changed the title check-source: ignore bootstrap*.css bareos-check-sources: ignore bootstrap*.css Sep 16, 2023
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Good work!

@BareosBot BareosBot merged commit ec19197 into bareos:master Sep 16, 2023
@joergsteffens joergsteffens deleted the dev/joergs/master/check-sources-ignore-bootstrap branch October 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants