stored: fix support for non-tape block-addressed devices#1554
Merged
BareosBot merged 9 commits intobareos:masterfrom Oct 18, 2023
Merged
stored: fix support for non-tape block-addressed devices#1554BareosBot merged 9 commits intobareos:masterfrom
BareosBot merged 9 commits intobareos:masterfrom
Conversation
8177240 to
07661e2
Compare
arogge
requested changes
Sep 21, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
As discussed I would love to have the network_order replaced with the super-naive implementation I made up.
Contributor
|
I'm proposing to add also the following patch to fix OP#5563 diff --git i/core/src/stored/butil.cc w/core/src/stored/butil.cc
index b71fca85c..ec5488439 100644
--- i/core/src/stored/butil.cc
+++ w/core/src/stored/butil.cc
@@ -145,7 +145,7 @@ static bool setup_to_access_device(DeviceControlRecord* dcr,
if (!VolumeName.empty()) {
bstrncpy(VolName, VolumeName.c_str(), sizeof(VolName));
if (VolumeName.size() >= MAX_NAME_LENGTH) {
- Jmsg0(jcr, M_ERROR, 0,
+ Jmsg0(jcr, M_FATAL, 0,
_("Volume name or names is too long. Please use a .bsr file.\n"));
}
} else {Comment is :
|
arogge
approved these changes
Oct 10, 2023
be8dee2 to
d064044
Compare
When a file is copied windows will only update the Creation time on the new file; it leaves the ChangeTime how it was. As such we need to take the CreationTime into account; otherwise newly copied files will not get backed up by incremental backups.
If a device wants to seek with the help of blocks/files, we should honor that and save the block/file numbers instead of the byte offsets.
network<T> is a wrapper for integral types that stores its contents in network byte order such that you can use memcpy to write to sockets in the correct byte order while offering ergonomic access to the actual number in the code itself.
9a8c8c8 to
e46871d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Currently bareos does some things differently if the target device is a tape. But in some of those cases it should consider all block based devices instead.
This PR also reverses the changes to ctime on windows, since after the change bareos did not pick up copied files correctly.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality