Skip to content

dird: list jobs: add level keyword and accept a list of job levels#1548

Merged
BareosBot merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/S5529-list-level-as-joblevel
Oct 6, 2023
Merged

dird: list jobs: add level keyword and accept a list of job levels#1548
BareosBot merged 4 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/S5529-list-level-as-joblevel

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Sep 12, 2023

Description

This PR add the level keyword that works as an alias to joblevel, and also enables the list jobs command to parse a list of job levels (i.e. list jobs level=F,I,D)

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura self-assigned this Sep 14, 2023
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I left some suggestions.

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/S5529-list-level-as-joblevel branch 2 times, most recently from 059bf19 to d3736df Compare September 20, 2023 13:48
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@BareosBot BareosBot force-pushed the dev/alaaeddineelamri/master/S5529-list-level-as-joblevel branch from 9e4916a to 0b6d678 Compare October 6, 2023 05:23
@BareosBot BareosBot merged commit 86a07a7 into bareos:master Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants