cats: fix for integer overflow issue when using offset in llist#1547
Merged
BareosBot merged 7 commits intobareos:masterfrom Oct 6, 2023
Conversation
OFFSET for a queryoffset in llist
sebsura
requested changes
Sep 13, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I think we should change it to 64bits; what do you think ?
3ab6fa6 to
d8643ea
Compare
sebsura
requested changes
Sep 14, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
You need to change the commit message too!
d8643ea to
a6f0783
Compare
sebsura
requested changes
Sep 19, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks great. During testing i realised that std::stoull throws an exception if the value is out of range which could crash the director.
This can be prevented with a simple try {} catch (...) {}.
sebsura
reviewed
Sep 19, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
We should also maybe have a test (in bareos-basic for example) that just executes a nonsense query (i.e. limit and offset way to high) and check that it handles it correctly (both for llist and list).
a6f0783 to
302603d
Compare
0bd62f7 to
4c0a013
Compare
sebsura
reviewed
Sep 21, 2023
97364d3 to
9f285c2
Compare
14 tasks
14 tasks
sebsura
approved these changes
Oct 6, 2023
added 6 commits
October 6, 2023 08:44
736ef5a to
6068506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a bug fix for the mantis bug 1027
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality
Tests