VMware Plugin: Fix transformer issues#1532
Merged
Conversation
pstorz
requested changes
Aug 31, 2023
docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc
Outdated
Show resolved
Hide resolved
11 tasks
686e545 to
8c486e3
Compare
The VMware Plugin can now recreate virtual machines which use VirtualPCIPassthrough or VirtualEnsoniq1371. Backup now terminates without warning in this case. Additionally, the vmware_cbt_tool.py can now dump the virtual machine config metadat to a JSON file, this can be helpful to debug issues with metadata transformation to recreate virtual machines.
The above properties can be missing, the plugin code now handles this properly so that backup jobs no longer cause false warnings.
The object_index of restore objects must always increase globally, not only within a job, because the SQL query uses ORDER BY ObjectIndex only. Otherwise restore objects could be processed in wrong order.
Unified setting controllerKey and unitNumber. Note in docs properly formatted now.
e3ef035 to
164f745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR fixes multiple issue with the transformation of VM config data for recreation of VMs on restore.
Additionally, the vmware_cbt_tool.py can now dump the virtual machine config metadata to a JSON file, this can be helpful to debug this type of issue.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality