build: remove python2 support#1520
Merged
BareosBot merged 16 commits intobareos:masterfrom Aug 24, 2023
Merged
Conversation
arogge
requested changes
Aug 22, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
Mostly trivial stuff. However, I'm not sure if the new python ldap plugin will still be tested with the patch applied. Maybe we need to double-check.
| if(Python2_FOUND) | ||
| list(APPEND DEBIAN_CONTROL_SNIPPETS "bareos-filedaemon-python2-plugin") | ||
| endif() | ||
| if(ENABLE_PYTHON AND Python3_FOUND) |
| AND ENABLE_PYTHON | ||
| AND (Python2_FOUND OR Python3_FOUND) | ||
| AND Python3_FOUND | ||
| ) |
Comment on lines
60
to
62
| %if ! 0%{?skip_python3} | ||
| %py3_build | ||
| %endif |
Member
There was a problem hiding this comment.
Suggested change
| %if ! 0%{?skip_python3} | |
| %py3_build | |
| %endif | |
| %py3_build |
| %endif | ||
|
|
||
| %if ! 0%{?skip_python3} | ||
| %py3_install |
d84a181 to
ca0071e
Compare
arogge
approved these changes
Aug 24, 2023
ca0071e to
a9e16a1
Compare
186c969 to
77a2d34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 is already EOL since January 1, 2020. This PR now removes Python2 support from bareos.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality