bsmtp: make mailhost and port message info a debug message#1507
Merged
BareosBot merged 2 commits intobareos:masterfrom Jul 12, 2023
Merged
Conversation
bruno-at-bareos
requested changes
Jul 12, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Maybe the variable name can be adjusted.
core/src/tools/bsmtp.cc
Outdated
|
|
||
| int mailport = default_port; | ||
| std::string mailhost = default_mailhost; | ||
| std::string mail_and_port_source = "Mailhost and mailport set to default"; |
Contributor
There was a problem hiding this comment.
What about host_and_port_source as variable name? I found it a bit less confusing.
02694df to
3321ce8
Compare
bruno-at-bareos
approved these changes
Jul 12, 2023
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Good Works. Ready for merge and backports
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When extracting the mailhost and port,
bsmtpwould show an info message that later would be interpreted as an error. This PR transforms it into a debug message.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality