plugin-fd: allow fd plugins to (re-)set since-time and disable/re-enable timestamp/accurate checks#1505
Merged
BareosBot merged 7 commits intobareos:masterfrom Aug 23, 2023
Conversation
dfce5f3 to
5921d59
Compare
sebsura
reviewed
Jul 11, 2023
sebsura
requested changes
Aug 11, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
All in all it looks good. I found some minor issues though.
systemtests/tests/py3plug-fd-basic/python-modules/force-backup-module.py
Show resolved
Hide resolved
d406000 to
a2ab828
Compare
sebsura
requested changes
Aug 21, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good. Ill approve once all the open conversations are addressed.
systemtests/tests/py3plug-fd-basic/python-modules/force-backup-module.py
Outdated
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/python-modules/force-backup-module.py
Show resolved
Hide resolved
systemtests/tests/py3plug-fd-basic/python-modules/force-backup-module.py
Outdated
Show resolved
Hide resolved
f85bbae to
bd316ed
Compare
bd316ed to
67ad1c5
Compare
14 tasks
This changeset enables a few things that were not possible before: override save_time in save_pkt, allowing a plugin to reset the effective since-time on a file-by-file basis. using SetValue() in a python plugin you can now reset since-time, which will also set or clear the incremental flag as needed. This allows a python plugin to call `SetValue(bVarSinceTime, 0)` to make sure the core will not decide to skip any of the files it provides.
This tests adds a plugin that backs up the same unchanged file in an incremental job, to make sure this is actually possible if desired.
2034e3c to
8fe4282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows a plugin to configure effective since-time on the client side. A plugin can now also disable calls to
CheckChanges()to avoid files being filtered out because of timestamps/accurate. For that a new plugin settingbVarCheckChangeswas added.This PR also removes non-working functionality from
SetValue()and does some refactoring.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineSource code quality
Tests