stored: automatically increment tape block size in case the buffer is too small#1496
Merged
BareosBot merged 4 commits intobareos:masterfrom Aug 17, 2023
Merged
Conversation
d5d1fa3 to
ab01b56
Compare
pstorz
reviewed
Jun 28, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Looks good; Please check my comment.
Member
Author
|
@sebsura I implemented what I think the both of us settled on. Would you mind taking another look? |
sebsura
requested changes
Jul 5, 2023
sebsura
reviewed
Jul 6, 2023
sebsura
reviewed
Jul 6, 2023
sebsura
reviewed
Aug 10, 2023
sebsura
reviewed
Aug 10, 2023
93bd51e to
833b83b
Compare
dist-tarball.sh was supposed to create "clean" tarballs, that is with a path-prefix of bareos-x.y.z based on the version-number. This didn't happen as rewriting in tar did not take place. With this patch the paths provided to tar are now all prefixed with './' which allows the substitution to work correctly.
when the unix_tape_device encounters a block that is too large for the buffer to handle, it will now re-read with incrementing buffer sizes until it can provide the first part of the block. This allows Bareos to reconfigure the block buffer size for tape devices like it already does for file devices.
When bsr() is called to initiare a re-read on a tape, it will decrement ths block_num. As during the re-read the block_num was not incremented, it shouldn't be decremented.
e3fad2c to
5b21b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows Bareos to read tape volumes even if the configured
Maximum Block Sizeis too small.You will still see an error message like this to notify you that something is not right:
However, restore will not fail anymore.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Check backport lineRequired backport PRs have been createdSource code quality