Skip to content

pr-tool: Add options to be used in CI runs#1488

Merged
pstorz merged 3 commits intobareos:masterfrom
arogge:dev/arogge/master/pr-tool-changes
Jun 26, 2023
Merged

pr-tool: Add options to be used in CI runs#1488
pstorz merged 3 commits intobareos:masterfrom
arogge:dev/arogge/master/pr-tool-changes

Conversation

@arogge
Copy link
Member

@arogge arogge commented Jun 22, 2023

  • it is now possible to skip the sanity checks (if you really know what you're doing).
  • you can now also pass --ignore-status-checks to the check subcommand so it will finish with zero exitcode even if a status-check was bad

These changes are needed to run the pr-tool during CI to facilitate automatic PR merges.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

arogge added 2 commits June 22, 2023 11:56
pr-tool check now also understands the --ignore-status-checks option so
you can ignore status checks just like it works for merge.
@arogge arogge force-pushed the dev/arogge/master/pr-tool-changes branch from d7b12e6 to 0b2f06b Compare June 22, 2023 09:56
@pstorz pstorz changed the title Add options to be used in CI runs to pr-tool pr-tool: Add options to be used in CI runs Jun 26, 2023
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz merged commit d845b37 into bareos:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants