VMware Plugin: improve snapshot cleanup#1484
Merged
Conversation
pstorz
requested changes
Jun 22, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work!
Please see comments.
Contributor
|
@pstorz I've committed the suggestions, do we want to squash the 4 commits to one, so easier to backport ? |
3affcfa to
0e7f740
Compare
10 tasks
0e7f740 to
177bfd3
Compare
If leftover snapshots exist from previous backups, they are now cleaned up before taking a new snapshot. Additionally, the snapshot cleanup after backup now works more reliable by reconnecting to the vCenter server if necessary. Code refactored to consequently use methods from pyVim.task. - fix a bug when folder=/ is used. Fixes: #1533: Restoring vmware vms keeps failing, can't restore the data - Fix restore when bootOrder was set When bootOrder was set to a virtualDisk at backup time, ensure the restore works by setting the bootOrder now after disks were added to the recreated VM. - Fix restore when virtualCdrom path is invalid Restore fails when recreating a VM and the backing file of a virtual CDROM is inaccessible, this can occur when it was connected to an ISO file on a NFS datastore which is not accessible at restore time. This change will then create a disconnected virtual CDROM to allow the restore to finish successfully. Co-authored-by: Philipp Storz <philipp.storz@bareos.com>
9d5535b to
ff1eac8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If leftover snapshots exist from previous backups, they are now cleaned up before taking a new snapshot. Additionally, the snapshot cleanup after backup now works more reliable by reconnecting to the vCenter server if necessary. Code refactored to consequently use methods from pyVim.task. Also fixes a bug when folder=/ is used.
Fixes: #1533: Restoring vmware vms keeps failing, can't restore the data.
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality