Skip to content

filed: fix off-by-one error when resizing acl buffer#1479

Merged
pstorz merged 2 commits intobareos:masterfrom
arogge:dev/arogge/master/plugin-acl-crash
Jun 7, 2023
Merged

filed: fix off-by-one error when resizing acl buffer#1479
pstorz merged 2 commits intobareos:masterfrom
arogge:dev/arogge/master/plugin-acl-crash

Conversation

@arogge
Copy link
Member

@arogge arogge commented Jun 5, 2023

When retrieving ACL data from a plugin, the buffer was not resized correctly, which might result in a buffer that is one byte to short so the null-termination could produce an overflow.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@pstorz pstorz force-pushed the dev/arogge/master/plugin-acl-crash branch from 1efed95 to 33b99ca Compare June 7, 2023 10:23
@pstorz pstorz merged commit 4e5aa28 into bareos:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants