Skip to content

python-bareos: add missing dirname variable#1460

Merged
pstorz merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/python-fix-test-dirname-missing
May 15, 2023
Merged

python-bareos: add missing dirname variable#1460
pstorz merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/python-fix-test-dirname-missing

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented May 8, 2023

  • fix systemtest failure system:python-bareos:filedaemon dirname is not defined

  • Short description and the purpose of this PR is present above this paragraph

  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos requested a review from pstorz May 15, 2023 09:13
@pstorz pstorz changed the title python-bareos: add missing dirname python-bareos: add missing dirname variable May 15, 2023
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

bruno-at-bareos and others added 3 commits May 15, 2023 11:40
- fix systemtest failure system:python-bareos:filedaemon
  `dirname is not defined`

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@pstorz pstorz force-pushed the dev/bruno/master/python-fix-test-dirname-missing branch from d9f427b to e043b02 Compare May 15, 2023 09:40
@pstorz pstorz merged commit 4f12b84 into bareos:master May 15, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/python-fix-test-dirname-missing branch June 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants