Skip to content

core: fix schema public with PostgreSQL 15#1449

Merged
pstorz merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/core-fix-postgresql15
Jun 1, 2023
Merged

core: fix schema public with PostgreSQL 15#1449
pstorz merged 3 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/core-fix-postgresql15

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Apr 17, 2023 •
edited by pstorz
Loading

In PostgreSQL 15 create/modify right were removed from public schema, making all temp tables creation failing.

  • This PR enables again the create right for the bareos database user.
  • For Debian dbconfig we now use the reassign owned instruction so view and function are also handled correctly.
  • ReadOnly user template is also renewed with schema.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch 2 times, most recently from 9af2c43 to 1fda344 Compare April 20, 2023 13:40
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch 2 times, most recently from 7ba00b5 to e638cc6 Compare May 8, 2023 08:39
@bruno-at-bareos bruno-at-bareos marked this pull request as ready for review May 8, 2023 08:39
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/core-fix-postgresql15 branch from e638cc6 to 3660d4c Compare May 8, 2023 12:01
@bruno-at-bareos bruno-at-bareos requested a review from arogge May 11, 2023 10:24
@bruno-at-bareos bruno-at-bareos requested review from pstorz and removed request for arogge May 11, 2023 10:25
pstorz
pstorz approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

bruno-at-bareos and others added 3 commits June 1, 2023 14:16
@bruno-at-bareos @pstorz
modernize grants sql to support postgresql>15
45ea37c 
- grant permission on public schema with postgresql>15.
- add views to reassign Debian dbconfig template.
- improve readonly grant sample sql script.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@pstorz
format: fix trailing newline in postgresql.sql
2456e65
@pstorz
Update CHANGELOG.md
1971139
@pstorz pstorz force-pushed the dev/bruno/master/core-fix-postgresql15 branch from 3f7819f to 1971139 Compare June 1, 2023 12:16
@pstorz pstorz merged commit 5b4d804 into bareos:master Jun 1, 2023
@pstorz pstorz mentioned this pull request Jun 9, 2023
Merged
7 tasks
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/core-fix-postgresql15 branch June 12, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstorz pstorz pstorz approved these changes

Assignees

@pstorz pstorz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bruno-at-bareos @pstorz