webui: create internal api module#1447
Merged
joergsteffens merged 46 commits intobareos:masterfrom Apr 20, 2023
frb121:dev/fbergkemper/master/webui-api
Merged
webui: create internal api module#1447joergsteffens merged 46 commits intobareos:masterfrom frb121:dev/fbergkemper/master/webui-api
joergsteffens merged 46 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/webui-api
Conversation
joergsteffens
requested changes
Apr 19, 2023
Member
joergsteffens
left a comment
There was a problem hiding this comment.
This looks like an good improvement and my tests have also been successful. I left a few remarks about improvements. None of them is strictly required, so feel free to either adapt the code accordingly or just mark close the remark with a comment.
joergsteffens
approved these changes
Apr 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organizes endpoint logic for HTTP requests in a dedicated module with new routing for data retrieval.
All of the old getData() controller actions are transfered into restful controller actions.
HTTP requests in views are adjusted to make use of the newly introduced routes and endpoints.
Furthermore, some refactoring is done besides a general clean up to remove stuff that is no longer
or not required.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality