Skip to content

check-sources: update check-sources ignores#1439

Merged
joergsteffens merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/check-sources
Apr 6, 2023
Merged

check-sources: update check-sources ignores#1439
joergsteffens merged 2 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/check-sources

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Apr 6, 2023

The Bareos/BSock vendor module should not be ignored by check-sources as we developed and maintain it.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@frb121 frb121 marked this pull request as ready for review April 6, 2023 13:54
@joergsteffens joergsteffens self-assigned this Apr 6, 2023
@sebsura sebsura added the nobuild label Apr 6, 2023
@sebsura
Copy link
Contributor

sebsura commented Apr 6, 2023

I set this pr to no build as there is no reason for ci to build this.

@frb121 frb121 changed the title check-sources: do not ignore Bareos/BSock module check-sources: update check-sources ignores Apr 6, 2023
The Bareos/BSock vendor module should not be ignored by
check-sources as we developed and maintain it.
@joergsteffens joergsteffens added documentation This PR changes only documentation and removed nobuild labels Apr 6, 2023
@joergsteffens joergsteffens merged commit 897e00f into bareos:master Apr 6, 2023
@frb121 frb121 deleted the dev/fbergkemper/master/check-sources branch April 21, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR changes only documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants