pr-tool: handling POEditor commits and optional github ci tests#1434
Merged
arogge merged 3 commits intobareos:masterfrom Jun 5, 2023
Merged
Conversation
Commit messages generated by the online tool https://POEditor.com don't contain a newline at the end of the headline. As we can't change this behavior, we don't emit a warning in this case. POEditor.com commit message do look like: "Update de_DE.mo (POEditor.com)"
8138772 to
eed6186
Compare
Depending how a PR is created, mutliple checks can exists in a PR. Only the ci check continuous-integration/jenkins/pr-merge is required for us, so we ignore other tests.
eed6186 to
7df23bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit messages generated by the online tool https://POEditor.com don't contain a newline at the end of the headline. As we can't change this behavior, we don't emit a warning in this case.
POEditor.com commit message do look like:
"Update de_DE.mo (POEditor.com)"
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality