Conversation
268d18a to
365c5ee
Compare
15 tasks
Contributor
|
We highly suspect that while a restore is scheduled the information about the volume is retrieved from the database, and bsr is written. The restore maybe is waiting previous jobs to free the media. |
Contributor
|
It look like we found the root cause, and we should be able to reproduce in a test the case. |
arogge
approved these changes
May 23, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
This is a good first step finding and fixing the underlying issue.
Merged
10 tasks
We have the effect that at the end of restores, we get catalog requests that try to reduce the VolFiles. Instead of emitting a fatal error, we now log the event and keep the current value. We do the same for VolBytes and for VolBlocks.
- Remove second unused parameter - Define enum type for first parameter (is_labeloperation)
9359472 to
60c53ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the effect that at the end of restores, we get catalog requests that try to reduce the VolFiles.
Instead of emitting a fatal error, we now log the event and keep the current value.
We do the same for VolBytes and for VolBlocks.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality