daemons: remove deprecated Pid Directory config option, and update Maximum Concurrent Jobs default value to 1#1426
Merged
pstorz merged 6 commits intobareos:masterfrom Apr 11, 2023
Conversation
Pid Directory config optionPid Directory config option, and update Maximum Concurrent Jobs default value to 1
sebsura
requested changes
Apr 3, 2023
Contributor
sebsura
left a comment
There was a problem hiding this comment.
There are still some mentions of piddir left over. For example in:
- environment.in
- cleanup
- BareosSystemtestFunctions.cmake
I think we should remove those as well if possible
a6beaa8 to
f18b25b
Compare
sebsura
requested changes
Apr 4, 2023
f18b25b to
3f6c75e
Compare
sebsura
requested changes
Apr 5, 2023
3f6c75e to
088bf81
Compare
sebsura
requested changes
Apr 5, 2023
088bf81 to
ffa92f9
Compare
sebsura
approved these changes
Apr 5, 2023
sebsura
requested changes
Apr 6, 2023
8f08ff9 to
04d08dd
Compare
sebsura
approved these changes
Apr 6, 2023
and update warnings text
96de3d3 to
b38cfa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description
This PR removes the already deprecated
Pid Directoryconfig option from all daemons, and updates theMaximum Concurrent Jobsconfig option default value to 1.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality