Merged
Conversation
e06cfbc to
6fc87de
Compare
pstorz
approved these changes
Apr 3, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Good work!
Please check the change in pull_request_template.
Contributor
Author
Now the question still exist do we want this backported to 22 ? Maybe a good idea for all of us that have or will have soon gcc13 as default (and a +1 bonus point as gcc13 detected newer issues we were not aware of). |
660bcdc to
a364db7
Compare
- add explicit system_error and stdexcept - console_conf.cc fix std::move warning Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
6f70691 to
3b3d2e7
Compare
Contributor
|
Thanks for the fix! there is one more missing include I discovered. In
there is missing this include:
After adding this the source compiles fine with gcc 13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propose fixes to add support of gcc-13 as compiler
Fix issue#1517
OP#539
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality