Skip to content

webui: remove some development leftovers and artefacts#1422

Merged
joergsteffens merged 5 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/spring-cleaning
Mar 30, 2023
Merged

webui: remove some development leftovers and artefacts#1422
joergsteffens merged 5 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/spring-cleaning

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Mar 23, 2023

Thank you for contributing to the Bareos Project!

Removes some development leftovers and artefacts.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@frb121 frb121 self-assigned this Mar 23, 2023
@frb121 frb121 requested a review from joergsteffens March 23, 2023 15:33
@frb121 frb121 marked this pull request as ready for review March 23, 2023 15:34
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-tool complains:

 ✗  bareos-check-sources --since=d127f5d02188fa00825d9837ea9b856810b560aa reported:
	Plugin 'fix copyright year' would modify 'webui/module/Job/view/job/job/timeline.phtml'
	Plugin 'fix copyright year' would modify 'webui/module/Restore/view/restore/restore/index.phtml'
	Plugin 'fix copyright year' would modify 'webui/module/Restore/view/restore/restore/versions.phtml'

@frb121
Copy link
Contributor Author

frb121 commented Mar 23, 2023

pr-tool complains:

 ✗  bareos-check-sources --since=d127f5d02188fa00825d9837ea9b856810b560aa reported:
	Plugin 'fix copyright year' would modify 'webui/module/Job/view/job/job/timeline.phtml'
	Plugin 'fix copyright year' would modify 'webui/module/Restore/view/restore/restore/index.phtml'
	Plugin 'fix copyright year' would modify 'webui/module/Restore/view/restore/restore/versions.phtml'

fixed

@frb121 frb121 requested a review from joergsteffens March 23, 2023 16:40
@joergsteffens joergsteffens merged commit 0eec896 into bareos:master Mar 30, 2023
@frb121 frb121 deleted the dev/fbergkemper/master/spring-cleaning branch April 21, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants