dird: keep copy and migration control/administrative jobs#1421
Merged
pstorz merged 6 commits intobareos:masterfrom Apr 6, 2023
Conversation
0475e51 to
838d3da
Compare
18865f8 to
0e3b844
Compare
pstorz
approved these changes
Apr 3, 2023
Member
pstorz
left a comment
There was a problem hiding this comment.
Just one small typo, see comments. Triggered to build again as last build was not successful.
| if [[ $(grep -c "| 3 |" "$query_results") -ne "2" ]]; then | ||
| echo "The necessary amount of migration related jobs are not available in the catalog." | ||
| if [[ $(grep -c "|.*M.*|" "$query_results") -ne "3" ]]; then | ||
| echo "Former backup jobs were not succesfully converted to 'Migrated Jobs'." |
Member
There was a problem hiding this comment.
Suggested change
| echo "Former backup jobs were not succesfully converted to 'Migrated Jobs'." | |
| echo "Former backup jobs were not successfully converted to 'Migrated Jobs'." |
0e3b844 to
d94c722
Compare
14 tasks
* added testing for copy upgrades * update impossible copy job test to accommodate volume pruning in 02-copy * test worker job deletion after new migrate jobs pruning
27c2cc1 to
9e5dd30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In bareos 22, copy and migration control/administrative jobs were deleted directly on completion. This turned out to not be suitable in certain situations where such information would be useful. This PR reverts that action and thus keep copy and migration control jobs jobs.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests