berrno_test.cc: accept both 271E and 273E#1407
Merged
Conversation
c77f54d to
7362313
Compare
The error string for bind_error_message can be both "No such file or directory (errno=2 | win_error=0x0000271E)" and "No such file or directory (errno=2 | win_error=0x0000273F)" depending on the windows cross chain. We now allow both.
7362313 to
5394724
Compare
Member
|
I have the strange feeling that something in the Windows error reporting is seriously broken. And from the kind of error-numbers we see here, that's a problem with berrno. |
arogge
approved these changes
Mar 15, 2023
This was referenced Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error string for bind_error_message can be both
"No such file or directory (errno=2 | win_error=0x0000271E)" and
"No such file or directory (errno=2 | win_error=0x0000273F)" depending on the windows cross chain.
We now allow both.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality