Skip to content

introduce php-cs-fixer and apply PSR-12 guidelines#1403

Merged
joergsteffens merged 11 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/php-cs-fixer
Mar 9, 2023
Merged

introduce php-cs-fixer and apply PSR-12 guidelines#1403
joergsteffens merged 11 commits intobareos:masterfrom
frb121:dev/fbergkemper/master/php-cs-fixer

Conversation

@frb121
Copy link
Contributor

@frb121 frb121 commented Mar 8, 2023 •
edited by joergsteffens
Loading

Thank you for contributing to the Bareos Project!

  • add PHP CS Fixer to devtools
  • add PHP chapter to the developers guide
  • apply PSR-12 extended coding style
    • fix indentation on php files
    • fix various PHP coding style issues
  • fix some minor bugs
  • refactor some code parts

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@frb121 frb121 self-assigned this Mar 8, 2023
@joergsteffens joergsteffens self-requested a review March 9, 2023 11:00
@frb121 frb121 changed the title add PHP CS Fixer to devtools introduce php-cs-fixer and apply PSR-12 guidelines Mar 9, 2023
joergsteffens
joergsteffens requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite good. I modified some minor things, please take a look.

joergsteffens
joergsteffens reviewed Mar 9, 2023
View reviewed changes
joergsteffens
joergsteffens approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All suggestions applied. Thank you. Please rebase, than we can merge.

@frb121
Copy link
Contributor Author

frb121 commented Mar 9, 2023

All suggestions applied. Thank you. Please rebase, than we can merge.

Rebased, feel free to merge and thanks for the review.

@joergsteffens joergsteffens merged commit 0aab9dc into bareos:master Mar 9, 2023
This was referenced Mar 13, 2023
Merged
Merged
@frb121 frb121 deleted the dev/fbergkemper/master/php-cs-fixer branch April 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joergsteffens joergsteffens joergsteffens approved these changes

Assignees

@frb121 frb121

Labels

jenkins_repotest_nodebug requires backport to 21 requires backport to 22

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@frb121 @joergsteffens