Skip to content

doc: improve plugin, webui, virtualfull chapters#1401

Merged
arogge merged 5 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/doc-use-python3-in-samples
Mar 30, 2023
Merged

doc: improve plugin, webui, virtualfull chapters#1401
arogge merged 5 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/doc-use-python3-in-samples

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Mar 7, 2023

This PR is a composite PR for several documentation changes. It is proposed to also backport this to branch-22

This PR propose to change Plugin Names = "python" samples to Plugin Names = "python3" in documentation: making it clear to everyone that parameter need to be adjusted depending on the python version you use.

This PR contain also the additional how-to enable php-fpm for apache in debian like distributions.

This PR contain the documentation changes about Virtual Full Backup can only be run on the same bareos-sd daemon.

This PR contain the documentation changes for bareos-webui installation under SLE12SP5 adding the PackageHub repository.

OP#5425
OP#5426
OP#5433
OP#5431

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos added documentation This PR changes only documentation requires backport to 22 labels Mar 7, 2023
@bruno-at-bareos bruno-at-bareos changed the title doc: use python3 in Plugin Name sample doc: use python3 in Plugin Name samples Mar 7, 2023
@joergsteffens joergsteffens requested a review from sduehr March 9, 2023 11:02
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-use-python3-in-samples branch from c27437d to 2561adf Compare March 21, 2023 14:20
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only few changes requested, and could you please also change to Plugin Names = python3 in VMwarePlugin.rst.inc?

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-use-python3-in-samples branch from b7e7642 to cebb76d Compare March 23, 2023 09:04
@bruno-at-bareos bruno-at-bareos requested a review from sduehr March 23, 2023 09:09
bruno-at-bareos and others added 3 commits March 23, 2023 10:15
- Help end users to move to python3 and don't get caught by
  module not loaded due to python version.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: sduehr <stephan.duehr@bareos.com>
- Virtual Full Backup need to be run on the same storage daemon,
  as the generated restore bsr file can be read by only one daemon.
- Add comment to Virtual Full Pool type definition

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-use-python3-in-samples branch from cebb76d to d41a878 Compare March 23, 2023 09:16
@bruno-at-bareos
Copy link
Contributor Author

Thanks, only few changes requested, and could you please also change to Plugin Names = python3 in VMwarePlugin.rst.inc?

Done in last push (forced then) added to first commit.

Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@bruno-at-bareos
Copy link
Contributor Author

We just add the fact that we want to add also the PackageHub needs for SL12SP5

@bruno-at-bareos bruno-at-bareos changed the title doc: use python3 in Plugin Name samples doc: improve plugin, webui, virtualfull chapters Mar 28, 2023
@bruno-at-bareos bruno-at-bareos requested a review from sduehr March 28, 2023 14:04
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-use-python3-in-samples branch 2 times, most recently from da6ab95 to a99f9a7 Compare March 28, 2023 14:50
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, only found a typo.

- PHP 7 or newer is recommended.

- On SUSE Linux Enterprise 12 you need the additional SUSE Linux Enterprise Module for Web Scripting 12.
- On SUSE Linux Enterprise 12 you need the additional SUSE Linux Enterprise Module for Web Scripting 12 and additionnal repository :strong:`Package Hub` to satisfy apache2-mod-fcgid requirement.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- On SUSE Linux Enterprise 12 you need the additional SUSE Linux Enterprise Module for Web Scripting 12 and additionnal repository :strong:`Package Hub` to satisfy apache2-mod-fcgid requirement.
- On SUSE Linux Enterprise 12 you need the additional SUSE Linux Enterprise Module for Web Scripting 12 and additional repository :strong:`Package Hub` to satisfy apache2-mod-fcgid requirement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. sorry.

- SLE12SP5 need special repository PackageHub installed and enabled
  to satisfy apache2-mod_proxy_fcgid dependency.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/doc-use-python3-in-samples branch from a99f9a7 to 8fc9316 Compare March 29, 2023 07:18
@bruno-at-bareos bruno-at-bareos requested a review from sduehr March 29, 2023 07:19
Copy link
Member

@sduehr sduehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@arogge arogge merged commit f3b07ae into bareos:master Mar 30, 2023
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/doc-use-python3-in-samples branch June 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This PR changes only documentation requires backport to 22

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants