dird: allow to disable TLS-PSK downgrades#1398
Merged
arogge merged 7 commits intobareos:masterfrom Mar 30, 2023
Merged
Conversation
9a76186 to
b688b58
Compare
arogge
requested changes
Mar 6, 2023
core/src/dird/dird_conf.cc
Outdated
| { "NdmpLogLevel", CFG_TYPE_PINT32, ITEM(res_client, ndmp_loglevel), 0, CFG_ITEM_DEFAULT, "4", NULL, NULL }, | ||
| { "NdmpBlockSize", CFG_TYPE_SIZE32, ITEM(res_client, ndmp_blocksize), 0, CFG_ITEM_DEFAULT, "64512", NULL, NULL }, | ||
| { "NdmpUseLmdb", CFG_TYPE_BOOL, ITEM(res_client, ndmp_use_lmdb), 0, CFG_ITEM_DEFAULT, "true", NULL, NULL }, | ||
| { "TlsDowngrade", CFG_TYPE_BOOL, ITEM(res_client, tls_downgrade), 0, CFG_ITEM_DEFAULT, "false", "23.0.0", |
Member
There was a problem hiding this comment.
I'm not sure that I'm happy with that naming.
Maybe it is worth investigating how TLS Require = yes would behave in that context. I think setting TLS Require = yes should not allow a downgrade to cleartext.
ddb210d to
605de11
Compare
52fbfd6 to
a943d28
Compare
14 tasks
arogge
approved these changes
Mar 30, 2023
Member
arogge
left a comment
There was a problem hiding this comment.
Looks good to me.
We should probably have a follow-up PR that changes the default for TLS Required to yes.
cce4232 to
39762de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Description
This PR disables TLS-PSK downgrades and allows to manually enable them in the configuration.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests